Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support major version bump of google-cloud-vision and google-cloud-pubsub #20991

Closed
damccorm opened this issue Jun 4, 2022 · 2 comments · Fixed by #24599
Closed

Support major version bump of google-cloud-vision and google-cloud-pubsub #20991

damccorm opened this issue Jun 4, 2022 · 2 comments · Fixed by #24599
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. new feature P3 python

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

In our project, we want to use apache-beam, but cannot due to having these dependencies:

 

google-cloud-pubsub==2.5.0

google-cloud-vision==2.0.0

Seems like the breaking change was due to "microgenerator"

https://github.com/googleapis/python-pubsub/releases

https://github.com/googleapis/python-vision/releases

(also dropping support for older versions of python)

 

What do we need to do to increase the version support defined here: 

'google-cloud-vision>=0.38.0,<2',

Imported from Jira BEAM-12498. Original Jira may contain additional context.
Reported by: sangm.

@tvalentyn
Copy link
Contributor

google-cloud-videointellingence also has breaking changes (#17615 ).

Things to do:

  1. increase upper bound (<3), increase (lower bound>=2)
  2. regenerate container dependencies
  3. run postcommit integration tests that exercise these deps
  4. fix any api incompatibilities.
  5. run tests again
  6. commit changes.

Assuming #4 doesn't require drastic changes, this shouldn't be too difficult, happy to provide further pointers if someone is interested to pick it up.

@AnandInguva
Copy link
Contributor

FYi, goolge-cloud-vision was updated and other GCP libraries will be updated as part of #24599

@github-actions github-actions bot added this to the 2.47.0 Release milestone Mar 15, 2023
@tvalentyn tvalentyn added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core done & done Issue has been reviewed after it was closed for verification, followups, etc. new feature P3 python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants