Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch bad FractionConsumed values in the beam SDK. #18181

Open
kennknowles opened this issue Jun 3, 2022 · 0 comments
Open

Catch bad FractionConsumed values in the beam SDK. #18181

kennknowles opened this issue Jun 3, 2022 · 0 comments

Comments

@kennknowles
Copy link
Member

getFractionConsumed in Sources are expected to return values between 0.0 and 1.0

I recently encountered a bug where a bad value of fractionConsumed was sent to a runner. Looking through the beam source, I couldn't find anywhere that we validate the value before we send it (it could be there and I didn't see it, but given that I saw this error with a real source, I don't believe it is.)

I think it'd be useful if the beam SDK caught this error at the time the value is returned and at least generate a useful error in the logs (thus allowing the user to more easily debug the issue)

Imported from Jira BEAM-1639. Original Jira may contain additional context.
Reported by: sisk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants