Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal_err! is over used in core code and should be replaced with exec_err! or plan_err! in many places #9164

Closed
Omega359 opened this issue Feb 8, 2024 · 4 comments · Fixed by #9241
Assignees
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Omega359 commented Feb 8, 2024

Describe the bug

internal_err! is used as a general error macro in many spots in the code where in fact the problem the error is propagating is not caused by an oversight, bug, etc in the code but rather by user error. A good example of this can be seen in PR #9137 comment where it's being used to let the user know they provided a datatype as an argument to a function that it doesn't support. This in fact should be an exec_err! in this example.

To Reproduce

No response

Expected behavior

In most cases where the error is caused by incorrect data types or invalid argument counts exec_err! should be used.

Additional context

No response

@comphead
Copy link
Contributor

comphead commented Feb 8, 2024

Related to #6108

@comphead
Copy link
Contributor

comphead commented Feb 8, 2024

looking fwd for the PR :)

@Omega359
Copy link
Contributor Author

take

@alamb
Copy link
Contributor

alamb commented Feb 28, 2024

Bug squashed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants