Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: add country map of bulgaria in superset-ui-legacy-plugin-chart-country-map #2

Merged
merged 1 commit into from
Feb 26, 2019
Merged

feat: add country map of bulgaria in superset-ui-legacy-plugin-chart-country-map #2

merged 1 commit into from
Feb 26, 2019

Conversation

djok
Copy link
Contributor

@djok djok commented Feb 24, 2019

…art-country-map

💔 Breaking Changes
NO
🏆 Enhancements
Add Bulgaria to list of countries in superset-ui-legacy-plugin-chart-country-map
📜 Documentation

🐛 Bug Fix

🏠 Internal

@djok djok requested a review from a team as a code owner February 24, 2019 19:30
@djok djok mentioned this pull request Feb 24, 2019
Merged
@mistercrunch
Copy link
Contributor

LGTM, I'm not sure what's up with the Travis build. Seems like issues on their side.

@djok
Copy link
Contributor Author

djok commented Feb 25, 2019 •
edited
Loading

How can we proceed, Do I have to open an issue about Travis? Can PR be merged to the master and NPM package released?

btw, I have also PR#6938@incubator-superset for plugin configuration.

@kristw
Copy link
Collaborator

kristw commented Feb 25, 2019

Thank you for your contribution. Looks good. I am about to add a few more things to master and will ask you to rebaseon top of master after that to see if it will help.

@ghost
Copy link

ghost commented Feb 26, 2019

There were the following issues with this Pull Request

  • Commit: 2f2a967
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Feb 26, 2019

There were the following issues with this Pull Request

  • Commit: ec16847
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Feb 26, 2019

There were the following issues with this Pull Request

  • Commit: 6848858
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@djok djok changed the title Add Bulgaria to the list of countries in superset-ui-legacy-plugin-chart-country-map feat: add country map of bulgaria in superset-ui-legacy-plugin-chart-country-map Feb 26, 2019
@ghost
Copy link

ghost commented Feb 26, 2019

There were the following issues with this Pull Request

  • Commit: da0ef58
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@djok
Copy link
Contributor Author

djok commented Feb 26, 2019

@kristw For some reason, Travis FAIL again.

@kristw
Copy link
Collaborator

kristw commented Feb 26, 2019

@djok I checked and the issue is not related to this PR. I will merge and take care of that.

@kristw kristw merged commit b5fd6e4 into apache-superset:master Feb 26, 2019
@djok
Copy link
Contributor Author

djok commented Feb 26, 2019

@kristw Any idea when NPM will be updated?

@kristw
Copy link
Collaborator

kristw commented Feb 26, 2019

Can publish by end of week, but there are a few breaking changes to @superset-ui that need to be addressed in incubator-superset so cannot just bump version number immediately.

@kristw kristw added the #enhancement New feature or request label Mar 14, 2019
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@williaster
[build] fix typescript builds (apache-superset#56)
4e9ea81 
* [build] fix typescript builds

* [typescript] ensure types pass in build

* [typescript][connection] declare modules in tests

* [typescript][connection] fix ts errors in tests

* [typescript][connection] test/types.ts => types/external.d.ts

* [chart][typescript] add @types/react-loadable

* [chart][components] convert to ts

* [charts][tests][broken] convert to ts

* [chart][typescript] re-write component generics

* [chart][typescript] fix reactify generic, add react-dom types

* [chart][typescript] more iteration

* - Tweaking reactify types (using Readonly types).
- Uncovered an issue in which ReactifyProps and Props can collide on id and className.
- Move @types/react-loadable to dev dependency
- Fixing a lint error

* [chart][deps] add @types/fetch-mock

* [client][typescript] add and export SupersetClientInterface

* [chart][clients] fix ts

* [charts][components] more ts iterations

* [chart][client] assert FormData type

* [chart][deps] try adding newest @types/react

* [chart][components][ts] fix reactify prop TS

* [chart] lint

* [chart][ts] lint #2, move @types to deps not dev-deps

* [chart][jest] fix tests

* [chart][tests] up branch coverage

* [chart][ts][test] null => undefined

* [chart][tests] hundo

* [chart][tests] update name

* [chart][ts] ChartClient type fixes
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@djok
feat: add country map of bulgaria in superset-ui-legacy-plugin-chart-…
ba113c2 
…country-map (#2)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
#enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djok @mistercrunch @kristw