This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: file skeleton necessary for icicle chart visualization #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update package to account for clearer name and reorganized implementation for planned features
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
======================================
Coverage 25.9% 25.9%
======================================
Files 8 8
Lines 166 166
Branches 10 10
======================================
Hits 43 43
Misses 122 122
Partials 1 1Continue to review full report at Codecov.
|
cguan7
changed the title
khtruong
reviewed
Jul 31, 2019
Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
khtruong
approved these changes
Aug 1, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…superset#162) * feat: file skeleton necessary for icicle chart visualization * feat: name changes and restructure components update package to account for clearer name and reorganized implementation for planned features * feat: fix lint errors * docs: add license file headers, adjust naming and links Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Initial PR to layout file skeleton to implement Icicle Chart