This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: tooltip disappearance and stickiness #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
approved these changes
Feb 25, 2019
xtinec
force-pushed
the
xtinec--fix-nvd3-tooltips
branch
from
78861e6
to
981c72c
Compare
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
xtinec
force-pushed
the
xtinec--fix-nvd3-tooltips
branch
from
981c72c
to
7e3f523
Compare
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
xtinec
force-pushed
the
xtinec--fix-nvd3-tooltips
branch
3 times, most recently
from
afde474
to
99247f0
Compare
This is a replication of PR #6898 in apache/incubator-superset Nvd3 attaches tooltips to the body of the dom, not the chart the tooltip is meant fo. On hover, it sets their opacity to 1. In order to address both their stickiness when chart reloads (PR #6805) and thier disappearance on scroll in dashboards (PR #6852), we introduce a shouldRemove parameter to `hideTooltips` and only remove them befor chart reloads. For the scroll events triggered on dashboards, we only hide the tooltips by setting their opacity to 0. When they get hovered over again, nvd3 sets their opacity to 1 which causes them to reappear.
xtinec
force-pushed
the
xtinec--fix-nvd3-tooltips
branch
from
99247f0
to
80b505e
Compare
kristw
changed the title
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
[SIP-4] add lerna monorepo and`@superset-ui/core` package with `SupersetClient`
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
…#1) fix: tooltip disappearance and stickiness
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This is a replication of PR #6898 in apache/incubator-superset
Nvd3 attaches tooltips to the body of the dom, not the chart the tooltip is meant fo. On hover, it sets their opacity to 1. In order to address both their stickiness when chart reloads (PR #6805) and thier disappearance on scroll in dashboards (PR #6852), we introduce a shouldRemove parameter to
hideTooltipsand only remove them befor chart reloads. For the scroll events triggered on dashboards, we only hide the tooltips by setting their opacity to 0. When they get hovered over again, nvd3 sets their opacity to 1 which causes them to reappear.