Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of "github.com/pkg/errors" #5293

Closed
shi0rik0 opened this issue Jul 21, 2023 · 0 comments · Fixed by #5317
Closed

Remove use of "github.com/pkg/errors" #5293

shi0rik0 opened this issue Jul 21, 2023 · 0 comments · Fixed by #5317
Labels
good first issue Good for newcomers kind/design Categorizes issue or PR as related to design.

Comments

@shi0rik0
Copy link
Contributor

The test/e2e/k8s_util.go uses the package "github.com/pkg/errors" which is no longer maintained (pkg/errors#245). I think we can get rid of it by replacing errors.Wrapf and errors.WithMessagef with fmt.Errorf, or we can probihit or discourage any new use of "github.com/pkg/errors".
@shi0rik0 shi0rik0 added the kind/design Categorizes issue or PR as related to design. label Jul 21, 2023
@luolanzone luolanzone added the good first issue Good for newcomers label Jul 21, 2023
@cr7258 cr7258 mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/design Categorizes issue or PR as related to design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove github.com/pkg/errors cr7258/antrea
2 participants
@shi0rik0 @luolanzone