Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aria-label): remove aria-label on non-interactive elements and adapt tests #128

Merged

Conversation

antoinezanardi
Copy link
Owner

Closes #104

@antoinezanardi antoinezanardi added the ✅ test Adding missing tests or correcting existing tests label Feb 14, 2024
@antoinezanardi antoinezanardi self-assigned this Feb 14, 2024
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoinezanardi antoinezanardi merged commit 2b67a66 into develop Feb 14, 2024
11 checks passed
@antoinezanardi antoinezanardi deleted the refactor/remove-aria-label-on-non-interactive-elements branch February 14, 2024 12:51
antoinezanardi pushed a commit that referenced this pull request Feb 14, 2024
## [1.5.0](v1.4.1...v1.5.0) (2024-2-14)

### 🚀 Features

* **cucumber:** generate html report with screenshots for failed scenarios ([#127](#127)) ([6b3a62a](6b3a62a))
* **game-lobby:** game lobby with basic game creation ([#97](#97)) ([6ffc1cf](6ffc1cf))

### ✅ Tests

* **aria-label:** remove aria-label on non-interactive elements and adapt tests ([#128](#128)) ([2b67a66](2b67a66)), closes [#104](#104)
* **titles:** change some test titles with "mounted" word ([#121](#121)) ([2c94e24](2c94e24)), closes [#105](#105)

### 🧹 Chore

* **dependabot:** better groups of updates ([#96](#96)) ([4807ddf](4807ddf))
* **deps:** bump @eslint/eslintrc from 3.0.0 to 3.0.1 ([#117](#117)) ([a6f9014](a6f9014))
* **deps:** bump @faker-js/faker from 8.4.0 to 8.4.1 ([#116](#116)) ([837f1d1](837f1d1))
* **deps:** bump @nuxtjs/i18n from 8.0.0 to 8.0.1 ([#91](#91)) ([18ba52c](18ba52c))
* **deps:** bump @nuxtjs/i18n from 8.0.1 to 8.0.2 ([#108](#108)) ([2ce54f3](2ce54f3))
* **deps:** bump @nuxtjs/i18n from 8.0.2 to 8.1.0 ([#114](#114)) ([af7af78](af7af78))
* **deps:** bump @nuxtjs/i18n from 8.1.0 to 8.1.1 ([#126](#126)) ([b579e1a](b579e1a))
* **deps:** bump @stylistic/eslint-plugin from 1.5.4 to 1.6.0 ([#102](#102)) ([1d68178](1d68178))
* **deps:** bump @stylistic/eslint-plugin from 1.6.0 to 1.6.1 ([#113](#113)) ([294d139](294d139))
* **deps:** bump husky from 9.0.10 to 9.0.11 ([#124](#124)) ([c19cb2b](c19cb2b))
* **deps:** bump lint-staged from 15.2.1 to 15.2.2 ([#103](#103)) ([0b51eff](0b51eff))
* **deps:** bump msw from 2.1.7 to 2.2.0 ([#125](#125)) ([6d03259](6d03259))
* **deps:** bump nuxt from 3.10.0 to 3.10.1 ([#100](#100)) ([43acac1](43acac1))
* **deps:** bump nuxt-primevue from 0.2.2 to 0.3.0 ([#119](#119)) ([9ec2ef4](9ec2ef4))
* **deps:** bump playwright from 1.41.1 to 1.41.2 ([#90](#90)) ([b5e1aa2](b5e1aa2))
* **deps:** bump playwright-core from 1.41.1 to 1.41.2 ([#93](#93)) ([20221e3](20221e3))
* **deps:** bump primevue from 3.47.2 to 3.48.0 ([#101](#101)) ([4ab7bf5](4ab7bf5))
* **deps:** bump primevue from 3.48.0 to 3.48.1 ([#109](#109)) ([0c81cc7](0c81cc7))
* **deps:** bump semantic-release from 23.0.0 to 23.0.1 ([#107](#107)) ([dc07d98](dc07d98))
* **deps:** bump semantic-release from 23.0.1 to 23.0.2 ([#110](#110)) ([1abb102](1abb102))
* **deps:** bump the commitlint group with 2 updates ([#122](#122)) ([d5a14d7](d5a14d7))
* **deps:** bump the eslint group with 1 update ([#106](#106)) ([72f5780](72f5780))
* **deps:** bump the stryker group with 4 updates ([#98](#98)) ([facd5fb](facd5fb))
* **deps:** bump the types group with 3 updates ([#120](#120)) ([b7197eb](b7197eb))
* **deps:** bump the types group with 3 updates ([#99](#99)) ([8bcb8ca](8bcb8ca))
* **deps:** bump tsx from 4.7.0 to 4.7.1 ([#118](#118)) ([309f742](309f742))
* **deps:** bump type-fest from 4.10.1 to 4.10.2 ([#94](#94)) ([1be46fa](1be46fa))
* **deps:** bump vue from 3.4.15 to 3.4.18 ([#112](#112)) ([83fbc6d](83fbc6d))
* **deps:** bump vue from 3.4.18 to 3.4.19 ([#123](#123)) ([a25355b](a25355b))
* **github-actions:** bump pnpm/action-setup from 2 to 3 ([#115](#115)) ([ed1e1ea](ed1e1ea))
@antoinezanardi
Copy link
Owner Author

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released ✅ test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant