Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to put the ts type into useMemo generics #44904

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: to put the ts type into useMemo generics #44904

merged 1 commit into from
Sep 15, 2023

Conversation

zqy1151215064
Copy link
Contributor

@zqy1151215064 zqy1151215064 commented Sep 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English to put the ts type into useMemo generics
🇨🇳 Chinese 将 ts 类型放入 useMemo 泛型中

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 98e1e96

Update TypeScript dependency and configuration, and improve code style and type safety in UploadList component.

🔍 Walkthrough

🤖 Generated by Copilot at 98e1e96

  • Add import * as React from 'react'; to explicitly import React as a namespace, required by TypeScript 4.5 (link, link)
  • Annotate listItemMotion with Partial<CSSMotionListProps> to declare its type and avoid type inference errors (link)

@stackblitz
Copy link

stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 15, 2023, 6:05 PM

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (05e15c0) 100.00% compared to head (98e1e96) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44904   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11540     11540           
  Branches      3105      3105           
=========================================
  Hits         11540     11540           
Files Changed Coverage Δ
components/upload/UploadList/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 7eb93ad into ant-design:master Sep 15, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants