Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

re-assign history after BFCache back #5425

Closed
wants to merge 1 commit into from

Conversation

kimwz
Copy link

@kimwz kimwz commented Dec 16, 2013

History variable should be handled like the location variable after BFCache back

@kimwz kimwz closed this Dec 16, 2013
@kimwz kimwz deleted the reassign-history-bfcacheback branch December 16, 2013 08:31
@kimwz kimwz restored the reassign-history-bfcacheback branch December 16, 2013 08:32
@kimwz kimwz reopened this Dec 16, 2013
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@ghost ghost assigned jeffbcross Dec 16, 2013
@kimwz
Copy link
Author

kimwz commented Dec 23, 2013

I signed the CLA. what should I do next?

@IgorMinar IgorMinar closed this in bddd46c Dec 30, 2013
@IgorMinar
Copy link
Contributor

merged. thanks

@ghost ghost assigned IgorMinar Dec 30, 2013
@IgorMinar
Copy link
Contributor

can you please sign the CLA one more time with email address you used in the commit (see: https://github.com/angular/angular.js/pull/5425.patch)

if you don't sign with that email address, I'll have to revert the commit.

thanks!

@kimwz
Copy link
Author

kimwz commented Dec 31, 2013

signed with the email

@IgorMinar
Copy link
Contributor

thanks!

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants