This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngRepeat): should correctly track elements even when the collection is initially undefined #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -282,9 +282,9 @@ var ngRepeatDirective = ['$parse', '$animate', function($parse, $animate) { | |||
|
|
|||
| if (isArrayLike(collection)) { | |||
| collectionKeys = collection; | |||
| trackByIdFn = trackByIdFn || trackByIdArrayFn; | |||
| trackByIdFn = trackByIdArrayFn || trackByIdFn; | |||
There was a problem hiding this comment.
to make the code more readable, could we rename the trackByIdFn in the outer scope to trackByIdExpFn and introduce a new variable called trackByIdFn in this ($watchCollection callback) scope. With that change the code is easier to understand and the bug will be fixed no matter what's the order of operands in this expression.
|
otherwise this looks great. thanks |
ghost
assigned
|
please add |
…on is initially undefined Closes angular#4145 Closes angular#3964
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
…nitially undefined Previously if the collection model was set to undefined on the first digest, the repeater would get confused and not use the correct tracking function for associating model with dom elements in the repeater. Closes angular#4145 Closes angular#3964
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
…nitially undefined Previously if the collection model was set to undefined on the first digest, the repeater would get confused and not use the correct tracking function for associating model with dom elements in the repeater. Closes angular#4145 Closes angular#3964
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3964