This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(compile): fix directives with controller, templateUrl and compile properties #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| controllerDirectives[directiveName], directive, $compileNode); | ||
| controllerDirectives[directiveName] = directive; | ||
| } | ||
| directiveValue = directive.controller; |
There was a problem hiding this comment.
given your change, this line looks unnecessary
There was a problem hiding this comment.
~500 tests break when I remove it.
There was a problem hiding this comment.
Actually, I tried to remove it again and it works.
|
Thanks Jan! I reviewed the code and this is the correct fix. |
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this pull request
Aug 10, 2013
This fixes regression introduced by angular#3514 (5c56011) - this commit is being reverted here and a better fix is included. The regression caused the controller to be instantiated before the isolate scope was initialized. Closes angular#3493 Closes angular#3482 Closes angular#3537
chirayuk
added a commit
to chirayuk/angular.js
that referenced
this pull request
Aug 21, 2013
This fixes regression introduced by angular#3514 (9c51d50) - this commit is being reverted here and a better fix is included. The regression caused the controller to be instantiated before the isolate scope was initialized. Closes angular#3493 Closes angular#3482 Closes angular#3537 Closes angular#3540
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following JSBin: http://jsbin.com/azomeh/9/edit
Directives combining templateUrl and a controller were not getting compiled correctly. The second call to
applyDirectivesToNodewas being made with thecontrollerproperty of the directive set tonullwhich made it impossible for the compiler to find the controller constructor function.