This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
$compile + ngRepeat + replace templates (fix #2151) #2155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only have tests that fail with infinite loop (async templates) or stack overflow (sync templates) right now. need help with the fix |
ghost
assigned 
|
Here are my fixes: https://github.com/mhevery/angular.js/tree/compiler-replace-fix-2151 |
|
@mhevery - what happened to your fixes branch? |
|
This is still failing in master: http://plnkr.co/edit/nfshYfXyJGvFUczqRSk1?p=preview |
|
This has been addressed at 15e1a29 |
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Jul 3, 2013
Previously if a template contained a directive that had a template (sync or async) and the directive template was to replace the original element and the directive template contained another directive on the root element of this template and this new directive was an element transclude directive then an infinite recursion would follow because the compiler kept on re-adding and reapplying the original directive to the replaced node. This change fixes that. Closes angular#2155
IgorMinar
added a commit
that referenced
this pull request
Jul 3, 2013
Previously if a template contained a directive that had a template (sync or async) and the directive template was to replace the original element and the directive template contained another directive on the root element of this template and this new directive was an element transclude directive then an infinite recursion would follow because the compiler kept on re-adding and reapplying the original directive to the replaced node. This change fixes that. Closes #2155
ctrahey
pushed a commit
to ctrahey/angular.js
that referenced
this pull request
Jul 22, 2013
Previously if a template contained a directive that had a template (sync or async) and the directive template was to replace the original element and the directive template contained another directive on the root element of this template and this new directive was an element transclude directive then an infinite recursion would follow because the compiler kept on re-adding and reapplying the original directive to the replaced node. This change fixes that. Closes angular#2155
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2151