(t *Torrent) Drop() isn't completely safe

[viciious]

Hi,

I have the following problem: calling Drop() on a torrent and immediately unlinking the file sometimes causes the following errors:

"*torrent.PeerConn 0xc000200008: error reading chunk for peer Request {219 {1474560 16384}}: EOF"
"*torrent.PeerConn 0xc000200008: error reading chunk for peer Request {219 {1884160 16384}}: EOF"
"*torrent.PeerConn 0xc000200008: error reading chunk for peer Request {219 {1540096 16384}}: EOF"
"*torrent.PeerConn 0xc000200008: error reading chunk for peer Request {219 {1556480 16384}}: EOF"

One would assume that no data is being read after dropping.

[anacrolix]

Well spotted. It's probable that the torrent close state isn't checked after attempting to read data to satisfy peer requests. It would be a small fix.

What is quoting your errors like that?

[viciious]

I'm using my own wrapper for structured logging, the quotes come from piping json logs to jq.