Preproc improvements #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes code use HashMap with string slices as keys. Also eliminate `Peekable` iterators.
|
Test failure on Travis seems to be unrelated to this changes. EDIT: It turned out to be not true |
Before this change the code effectively discarded the last common character
Previously the code would make "prefixprefixret" into "prefix"
`std::str::Chars` is slow since it have to construct codepoints and thus should be avoided. With a small adjustments finding a common byte prefix is sufficient and compiles into more efficient code (compiler vectorized the comparison loop)
jpeddicord
reviewed
Dec 18, 2019
jpeddicord
reviewed
Dec 20, 2019
|
Merged! Thanks again. I'll get things ready for a new release soon, likely right after the holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This series of commits simplifies implementations of
lcs_substrandremove_common_tokensas well as greatly reducing amount of memory allocations. Functionality is preserved, all tests pass.Note: in
lcs_substrthe common prefix is.trim()ed. However, if this common prefix happens to start with whitespace characters, this will give wrong results later inremove_common_tokens. It seems like it actually should be.trim_end().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.