From bc144113f14d448bd035b8fc8b6282022700dd13 Mon Sep 17 00:00:00 2001 From: Cliff Engle Date: Wed, 18 Apr 2012 18:20:58 -0700 Subject: [PATCH] Fix TextConverter inefficiency --- .../primitive/PrimitiveObjectInspectorConverter.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java b/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java index 9d8ab9a5290b..fea46c66ffb3 100644 --- a/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java +++ b/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java @@ -289,7 +289,11 @@ public Text convert(Object input) { t.set(String.valueOf(((DoubleObjectInspector) inputOI).get(input))); return t; case STRING: - t.set(((StringObjectInspector) inputOI).getPrimitiveJavaObject(input)); + if (inputOI.preferWritable()) { + t.set(((StringObjectInspector) inputOI).getPrimitiveWritableObject(input)); + } else { + t.set(((StringObjectInspector) inputOI).getPrimitiveJavaObject(input)); + } return t; default: throw new RuntimeException("Hive 2 Internal error: type = " + inputOI.getTypeName());