Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(danger): validate lockfiles #7

Merged
merged 6 commits into from
Jan 14, 2020
Merged

feat(danger): validate lockfiles #7

merged 6 commits into from
Jan 14, 2020

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Jan 1, 2020 •
edited
Loading

Extends danger.js to validate lock files, hosts and protocol of package resolutions are checked.
Adding lockfile-lint to run on test:lint script.

@Francois-Esquire Francois-Esquire requested a review from a team January 1, 2020 18:56
JAdshead
JAdshead suggested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@JAdshead JAdshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea and might be worth including on our other packages if everyone agrees.

scripts/dangers/keep-package-and-lock-in-sync.js Outdated Show resolved Hide resolved
scripts/dangers/keep-package-and-lock-in-sync.js Outdated Show resolved Hide resolved
@anescobar1991
Copy link
Member

Should we just add lockfile-lint to the npm test script and not rely on danger to run it?

@nellyk nellyk self-requested a review January 8, 2020 11:59
@nellyk
Copy link
Contributor

nellyk commented Jan 8, 2020

Should we just add lockfile-lint to the npm test script and not rely on danger to run it?

I think i would prefer it staying with danger as we are validating whether the package-lock submitted via the pr is valid. It would be still be captured.

Mike Tobia and others added 5 commits January 13, 2020 12:32
feat(danger): validate lockfiles
21193a4
@Francois-Esquire @JAdshead
fix(type-check): prevent cannot read prop
b032aed 
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
@Francois-Esquire @JAdshead
fix(type-check): prevent cannot read prop from type
d0ff851 
Co-Authored-By: Jonny Adshead <JAdshead@users.noreply.github.com>
fix(lint): word spacing
270b585
feat(lockfile-lint): command-line hook
07e2fd2
@Francois-Esquire
Copy link
Contributor Author

@nellyk @anescobar1991 updated to use command-line tool per team discussion.

10xLaCroixDrinker
10xLaCroixDrinker suggested changes Jan 13, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@JAdshead JAdshead merged commit 1e560f7 into master Jan 14, 2020
@JAdshead JAdshead deleted the feature/lockfile-validation branch January 14, 2020 18:15
@nellyk nellyk added the enhancement New feature or request label Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

@mtomcal mtomcal mtomcal approved these changes

@nellyk nellyk nellyk approved these changes

@JAdshead JAdshead JAdshead approved these changes

@anescobar1991 anescobar1991 anescobar1991 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Francois-Esquire @anescobar1991 @nellyk @10xLaCroixDrinker @mtomcal @JAdshead