Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(one-app): removed tenancy or tenant instances #69

Merged
merged 21 commits into from
Apr 29, 2020

Conversation

NarmeenNaveedAhmed
Copy link
Contributor

@NarmeenNaveedAhmed NarmeenNaveedAhmed commented Mar 16, 2020

Description

This PR is for removing/replacing(where needed) all the instances of tenancy and tenant.

Motivation and Context

This is to ensure consistency in the code base and to keep it generic.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

The idea is to keep it as generic so specific keywords like tenant or tenancy do not cause any confusion for developers.

@NarmeenNaveedAhmed NarmeenNaveedAhmed requested a review from a team as a code owner March 16, 2020 12:38
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2020

CLA assistant check
All committers have signed the CLA.

@oneamexbot
Copy link
Contributor

oneamexbot commented Mar 16, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.4KB 38KB
app~vendors.js 405.9KB 105.9KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163.4KB 44.9KB
legacy/app~vendors.js 412KB 107.6KB

Generated by 🚫 dangerJS against cd0c9f6

JamesSingleton
JamesSingleton previously approved these changes Mar 24, 2020
__tests__/integration/one-app.spec.js Outdated Show resolved Hide resolved
__tests__/integration/one-app.spec.js Outdated Show resolved Hide resolved
__tests__/integration/one-app.spec.js Outdated Show resolved Hide resolved
__tests__/integration/one-app.spec.js Outdated Show resolved Hide resolved
__tests__/integration/one-app.spec.js Outdated Show resolved Hide resolved
src/server/middleware/sendHtml.js Outdated Show resolved Hide resolved
src/server/utils/onModuleLoad.js Outdated Show resolved Hide resolved
src/server/utils/safeRequest.js Outdated Show resolved Hide resolved
src/server/utils/stateConfig.js Outdated Show resolved Hide resolved
__tests__/server/utils/onModuleLoad.spec.jsx Outdated Show resolved Hide resolved
__tests__/server/utils/onModuleLoad.spec.jsx Outdated Show resolved Hide resolved
__tests__/universal/routes.spec.jsx Outdated Show resolved Hide resolved
@nellyk nellyk requested a review from a team as a code owner April 3, 2020 13:53
@JAdshead JAdshead requested a review from mtomcal April 28, 2020 20:58
@NarmeenNaveedAhmed NarmeenNaveedAhmed merged commit 1b6a5e5 into master Apr 29, 2020
@JamesSingleton JamesSingleton deleted the feature/remove-tenancy-or-tenant-instances branch September 7, 2020 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants