Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(stateConfig): use localhost rather than ip for dev #63

Merged

Conversation

anescobar1991
Copy link
Member

@anescobar1991 anescobar1991 commented Mar 13, 2020

In order to start using One App Runner we need One App to make calls to the dev-proxy server using localhost rather than the resolved IP address. The reason is that when running One App as a docker container the IP address inside that container is not resolvable by the host.

Description

Updated the state config modifications we make when there is a dev.endpoints.js file to use localhost rather than the IP address

Motivation and Context

In order to start using One App Runner we need One App to make calls to the dev-proxy server using localhost rather than the resolved IP address. The reason is that when running One App as a docker container the IP address inside that container is not resolvable by the host.

How Has This Been Tested?

Unit tests were updated and made sure to run locally with parrot and a dev endpoints file.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Allows them to use one app runner

@anescobar1991 anescobar1991 requested a review from a team as a code owner March 13, 2020 18:35
mtomcal
mtomcal previously approved these changes Mar 13, 2020
@anescobar1991 anescobar1991 force-pushed the bugfix/use-localhost-rather-than-ip-for-dev-state-config branch from 9b40e2b to 73dc323 Compare March 13, 2020 18:50
mtomcal
mtomcal previously approved these changes Mar 13, 2020
JamesSingleton
JamesSingleton previously approved these changes Mar 13, 2020
@oneamexbot
Copy link
Contributor

📊 Bundle Size Report

file name size on disk gzip
app.js 112.7KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 403.5KB 105.2KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 409.8KB 106.9KB

Generated by 🚫 dangerJS against 5bbaf1a

@JamesSingleton JamesSingleton merged commit de051d9 into master Mar 13, 2020
@JamesSingleton JamesSingleton deleted the bugfix/use-localhost-rather-than-ip-for-dev-state-config branch March 13, 2020 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants