Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Bug fixes for mocking data #54

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

enuchi
Copy link

@enuchi enuchi commented Mar 4, 2020

Description

  • FIx csp directives to include dev proxy server port.
  • Fix path joining in state config.

Motivation and Context

Solves csp directives not including dev proxy server port.
Solves incorrect double slash // in path naming.

How Has This Been Tested?

Includes tests to validate desired behavior.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Dev proxy server port should appear on csp directives, allowing proper testing with parrot.
Allows defining paths in mock endpoints with leading or no leading slash.

@enuchi enuchi requested a review from a team as a code owner March 4, 2020 21:43
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2020

CLA assistant check
All committers have signed the CLA.

anescobar1991
anescobar1991 previously approved these changes Mar 4, 2020
JamesSingleton
JamesSingleton previously approved these changes Mar 4, 2020
@enuchi
Copy link
Author

enuchi commented Mar 4, 2020

Sorry, had to rewrite commits to add email address so I could add signed CLA. @JamesSingleton can you pull in master again if needed?

@JamesSingleton
Copy link
Contributor

Here is the bundle size report:

📊 Bundle Size Report

file name size on disk gzip
app.js 112.7KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 403.5KB 105.2KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 409.8KB 106.9KB

@anescobar1991 anescobar1991 merged commit 6c6631c into americanexpress:master Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants