Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(fetch): upgrade bundler to add fetch polyfills #289

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

infoxicator
Copy link
Contributor

americanexpress/one-app-cli#135

Description

Updated one-app-bundler to 6.10.0 which contains the cross-fetch and abort-controller polyfills added to the client bundle when bundling One App

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@infoxicator infoxicator requested review from a team as code owners August 28, 2020 16:16
@github-actions github-actions bot added the fix label Aug 28, 2020
@oneamexbot
Copy link
Contributor

oneamexbot commented Aug 28, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 172.7KB 47.1KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against d5568be

@infoxicator infoxicator merged commit f81e8c5 into master Aug 28, 2020
@infoxicator infoxicator deleted the fix/ie11-fetch-polyfill branch August 28, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants