Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(pwa): reset config when not supplied #283

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Aug 21, 2020

Fixes a bug when the config is not set.

Description

The config relied on pre-processing before creating it - recent addition removed this pre-processing when validation was moved.

How Has This Been Tested?

Locally

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Fixes bug for users using service worker

@Francois-Esquire Francois-Esquire requested review from a team as code owners August 21, 2020 17:56
@github-actions github-actions bot added the fix label Aug 21, 2020
@oneamexbot
Copy link
Contributor

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against a2a6520

@mtomcal
Copy link
Contributor

mtomcal commented Aug 21, 2020

Do we need to have an Integration test to ensure this bug is covered?

@Francois-Esquire
Copy link
Contributor Author

Do we need to have an Integration test to ensure this bug is covered?

@mtomcal
The bug was a type error for an edge case from what we've seen. I think the current integration tests do cover both paths of enabling/disabling already so that should ensure the SW can be used safely when turned on/off.

@JAdshead JAdshead merged commit 6784c7c into master Aug 24, 2020
@JAdshead JAdshead deleted the fix/service-worker-config branch August 24, 2020 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants