Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(metrics): health check #274

Merged
merged 3 commits into from
Aug 13, 2020
Merged

fix(metrics): health check #274

merged 3 commits into from
Aug 13, 2020

Conversation

JAdshead
Copy link
Contributor

Description

health check was using an old api of pidusage.

Motivation and Context

fixes failing health check.

How Has This Been Tested?

locally by starting one-app and calling /im-up on port 3005. before was failing, now returning expected stats

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners August 11, 2020 21:28
@oneamexbot
Copy link
Contributor

oneamexbot commented Aug 11, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 32327b3

Copy link
Contributor

@infoxicator infoxicator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this error before, don't think we are using that endpoint but good catch

@JAdshead JAdshead merged commit 352bbd3 into master Aug 13, 2020
@JAdshead JAdshead deleted the fix/health-check branch August 13, 2020 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants