Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARIADB_PORT should be read from ENV VARS, not hardcoded #17

Closed
tobybellwood opened this issue Aug 10, 2023 · 0 comments · Fixed by #18
Closed

MARIADB_PORT should be read from ENV VARS, not hardcoded #17

tobybellwood opened this issue Aug 10, 2023 · 0 comments · Fixed by #18

Comments

@tobybellwood
Copy link
Member

tobybellwood commented Aug 10, 2023 •
edited
Loading

Some DBaaS providers don't provision 3306, so the mariadb can be on another port. We already create the variable, this should reference it.

drupal-integrations/assets/settings.lagoon.php

Line 40 in f5d4ddd

'port' => 3306,

Reference https://docs.digitalocean.com/glossary/port/#mysql-postgresql-redis - DigitalOcean uses 25060
@tobybellwood tobybellwood changed the title Mariadb Port should be read from ENV VARS, not hardcoded MARIADB_PORT should be read from ENV VARS, not hardcoded Aug 10, 2023
@tobybellwood tobybellwood mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use MARIADB_PORT variable in database settings amazeeio/drupal-integrations
1 participant
@tobybellwood