Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings and mixins for building IE8 specific stylesheets #3461

Closed
1 of 2 tasks
Tracked by #2621
romaricpascal opened this issue Mar 31, 2023 · 1 comment · Fixed by #3559
Closed
1 of 2 tasks
Tracked by #2621

Remove settings and mixins for building IE8 specific stylesheets #3461

romaricpascal opened this issue Mar 31, 2023 · 1 comment · Fixed by #3559
Assignees
Milestone

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Mar 31, 2023

What

Remove the Sass settings and mixins used for building IE8 specific stylesheets, including:

  • the $govuk-is-ie8 setting
  • the $govuk-ie8-breakpoint setting
  • the govuk-if-ie8 mixin
  • the govuk-not-ie8 mixin

Why

We're dropping support for IE8 in v5 so we no longer need the mixins for outputing IE8 specific code

Who needs to work on it

Developers

Who needs to review it

Developers

Done when

  • The mixins and settings have been removed from the code
  • References to these mixins and settting in the docs have been removed
@querkmachine
Copy link
Member

We've decided to handle the docs changes after all of the IE removals have taken place, rather than doing them piecemeal, so I'm closing this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants