Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header is inconsistent with GOV.UK header #2381

Closed
1 of 2 tasks
christopherthomasdesign opened this issue Oct 14, 2021 · 2 comments
Closed
1 of 2 tasks

Header is inconsistent with GOV.UK header #2381

christopherthomasdesign opened this issue Oct 14, 2021 · 2 comments

Comments

@christopherthomasdesign
Copy link
Member

christopherthomasdesign commented Oct 14, 2021

What

GOV.UK (as in the central website) recently shipped a new header as part of improvements to the site navigation. After a successful A/B test this has now gone live for all users.

It has a few stylistic inconsistencies with the header that services use, mostly the spacing and different states:

Basic Design System header used by services:
Screenshot 2021-10-14 at 11 35 38

GOV.UK header:
Screenshot 2021-10-14 at 11 35 48

We need to work with the GOV.UK team to work out the best way to align the two.

If we made a change to the header in the Design System, it would be a visually significant change, and would affect any teams that have written custom CSS for their header. Which means ideally any changes would be made as part of #2274.

Why

  • so GOV.UK continues to look like one website
  • so hover and focus states are treated consistently across GOV.UK and its services

Who needs to work on this

Designer, developer

Who needs to review this

Designer, developer

Done when

  • Teams agreed on what needs to change and where
  • Made a plan for implementing any changes to the header in Frontend or GOV.UK
@christopherthomasdesign
Copy link
Member Author

Update: had conversation with designers on GOV.UK, agreed to change padding on the GOV.UK header to match that in the Design System one. No definite date on when this will happen yet.

@vanitabarrett vanitabarrett removed this from the v4.0.0 milestone Dec 9, 2021
@vanitabarrett vanitabarrett removed the awaiting triage Needs triaging by team label Dec 14, 2021
@christopherthomasdesign
Copy link
Member Author

The GOV.UK header has now been changed to reflect the spacing in the Design System version, so going to close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants