Firefox extension omits : after http(s)

[jnv]

Steps to reproduce

1. Install BT extension for Firefox
2. Click the extension button on some website
3. Open link from BT in any browser

Expected behavior

The new browser opens the original link.

Actual behavior

The new browser opens the original link without : after https, resulting in connection error page, for example: https//github.com

Notes

Since there were no recent releases of BT or the extension, I suspect this could be caused by very recent update of Firefox to v122. Extension in Edge seems unaffected.

Versions:

• Windows 11 Enterprise, Version 22H2, OS build 22621.3007
• Firefox 122.0 (64-bit)
• Extension: 1.2.1
• BT 3.6.2

[jnv]

Hmm, I'm thinking whether there was a change in URL handling mechanism:

bt/browser-extensions/firefox/background.js

Lines 18 to 20 in 4572ed2

	browser.tabs.update(tab.id, {
	url: "x-bt://" + url
	});

The URL added after x-bt:// isn't encoded, so it's possible Firefox trims the : character in order to perhaps prevent some security issue?

[aloneguid]

Thanks, I can reproduce this on my Firefox, and it used to work (nothing changed since then) so it's definitely something in the Firefox itself. Will keep digging and come up with a fix.

[aloneguid]

I can confirm Firefox it removing : - the URL arrives to BT without it. 3.7.2 will fix this issue.

[aloneguid]

Please try installing 3.7.2. Firefox extension does not need an update.

[jnv]

Thank you Ivan! I'm off for a week, but will try it first thing once I'm back.

[jnv]

@aloneguid The fix works for me in BT v3.7.3. Thank you Ivan!