Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the SDK and algod agree on encoding #272

Closed
jasonpaulos opened this issue Feb 1, 2021 · 1 comment · Fixed by #280
Closed

Make sure the SDK and algod agree on encoding #272

jasonpaulos opened this issue Feb 1, 2021 · 1 comment · Fixed by #280
Assignees
@jasonpaulos
Labels
FDE

Comments

@jasonpaulos
Copy link
Contributor

Summary

If the lease or assetMetadataHash fields of Transaction are encoded in a way inconsistant with algod, signatures generated by this SDK will appear to be invalid to algod.

Scope

Make sure that the SDK correctly validates and omits (when empty) the lease and assetMetadataHash fields.

Urgency

This is a small but important fix.
@jasonpaulos jasonpaulos added the FDE label Feb 1, 2021
@jasonpaulos
Copy link
Contributor Author

This probably also affects the asset manager fields in an asset config txn as well.

@jasonpaulos jasonpaulos self-assigned this Feb 18, 2021
@jasonpaulos jasonpaulos mentioned this issue Feb 19, 2021
Merged
@ian-algorand ian-algorand removed this from the Sprint 19 - Meandering Trail milestone Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonpaulos jasonpaulos

Labels
FDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix encoding of all 0 lease and assetMetadataHash algorand/js-algorand-sdk
2 participants
@jasonpaulos @ian-algorand