Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Chrome autofill when event.key is undefined #1888

Merged
merged 2 commits into from
May 17, 2023
Merged

fix: support Chrome autofill when event.key is undefined #1888

merged 2 commits into from
May 17, 2023

Conversation

powerfulyang
Copy link
Contributor

@powerfulyang powerfulyang commented May 16, 2023 •
edited by francoischalifour
Loading

image I always encounter errors with input autocomplete when using Next.js, and it's quite frustrating.

Closes #1887.

@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

👷 Deploy request for docsearch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e4bce7e

shortcuts
shortcuts reviewed May 16, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for RSC or SSR purposes? looking at the types, it can't be undefined, but if this check solves it, it's not a huge deal to me

cc @francoischalifour wdyt?

@powerfulyang
Copy link
Contributor Author

chrome autocomplete in forms triggers 'keydown' but the event.key is undefined

@powerfulyang
Copy link
Contributor Author

powerfulyang commented May 16, 2023 •
edited
Loading

Maybe KeyboardEvent type is incorrect.

https://www.w3.org/TR/uievents-key/#key-attr-values

or it's a chrome BUG.

paperjs/paper.js#1398
paperjs/paper.js@f1a0c0a

francoischalifour
francoischalifour reviewed May 16, 2023
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/docsearch-react/src/useDocSearchKeyboardEvents.ts Show resolved Hide resolved
@powerfulyang
Copy link
Contributor Author

scrnli_2023_5_16 20-27-03.webm
the auto-filling from chrome which registers as an undefined key

@powerfulyang @francoischalifour
Update packages/docsearch-react/src/useDocSearchKeyboardEvents.ts
e4bce7e 
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
@powerfulyang
Copy link
Contributor Author

English is not my native language; please forgive me if I offend you in any way.

@francoischalifour francoischalifour changed the title fix: event.key is undefined #1887 fix: support Chrome autofill when event.key is undefined May 16, 2023
@francoischalifour
Copy link
Member

@powerfulyang Nope, nothing to worry about 🙂 Thanks for your contribution!

shortcuts
shortcuts approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

@shortcuts shortcuts merged commit 3f15fdb into algolia:main May 17, 2023
@melloware melloware mentioned this pull request Jun 30, 2023
Closed
@OKEAMAH OKEAMAH mentioned this pull request May 27, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@q1blue q1blue mentioned this pull request Jun 26, 2024
Open
This was referenced Jul 7, 2024
Open
Open
@q1blue q1blue mentioned this pull request Aug 6, 2024
Open
This was referenced Aug 7, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

@shortcuts shortcuts shortcuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chrome autocomplete in forms triggers 'keydown' but the event.key is undefined
3 participants
@powerfulyang @francoischalifour @shortcuts