fix: Correctly type getMissingResultsUrl
query as string
#1781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
({ query: string }) => string;
was being interpreted as a prop rename, which doesn't make sense in the context of an interface, so I've corrected it to what I assume was the intended outcome wherequery
is of typestring
, rather than being inferred asany
.NOTE: Technically this is a breaking change as
query
was being inferred with typeany
, so consumers that were using it as such may need to change their code. On the other hand, I doubt many consumers are using this value as if it were anything but astring
, so IMO a patch fix is also valid in this case. I'll leave this decision to the maintainers.