Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _linux_detect.py to add initial support for freedesktop standard on gnome #22

Merged

Conversation

raghavdhingra24
Copy link
Contributor

@raghavdhingra24 raghavdhingra24 commented May 29, 2022

The original code only used the names of gtk-themes for checking of dark mode. Now, I have added support for the new freedesktop standard for checking dark mode in gnome as newer versions of gnome use this for setting dark mode.

Currently had not updated the code for the listener.

@raghavdhingra24 raghavdhingra24 changed the title Update _linux_detect.py to support freedesktop standard on gnome Update _linux_detect.py to add initial support for freedesktop standard on gnome May 29, 2022
@albertosottile
Copy link
Owner

I apologize, I was on vacation in the end of May and I missed this entirely. Does the command with color-scheme trigger an error when called on unsupported systems?

@raghavdhingra24
Copy link
Contributor Author

No problem, I have tried it on Gnome 40 (it has no support for the freedesktop standard) it had successfully reverted to gtk-theme for getting the current theme of the system.

@albertosottile albertosottile merged commit 44008e2 into albertosottile:master Dec 6, 2022
@albertosottile
Copy link
Owner

Thanks again for this PR, I apologize if it took me so long for merging it. You will find this feature in the next release.

@raghavdhingra24
Copy link
Contributor Author

Thank you for merging this PR,
additionally I would keep an eye if this creates any issues with the detection of dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants