Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft fail if reckon isn't configured by the time version.toString() is called #174

Closed
ajoberstar opened this issue Feb 18, 2022 · 0 comments
Labels

Comments

@ajoberstar
Copy link
Owner

As noted in #147, reckon sometimes isn't fully configured in time for other plugins that want to use the version.

One way to resolve this situation is to change the hard fail when reckon isn't fully configured to a soft fail. Return unspecified as the version value, but allow later attempts to use a reckoned version, presuming it is configured. Log a warning indicating reckon was evaluated too early (but only one of them) and log info level stacktraces each time it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant