Reformatted dns::key and wrote tests for it #48
Conversation
|
Commit 863bf3f will cause travis to start failing, but that's because it adds lint tests to the test suite. I think we need to keep this and start working on lint. |
|
Lets lint it up! |
|
👍 |
|
Let me know if you want to divide the work, I could say, fix the errors for stuff in the record folder? |
|
Ok! I'll take everything under manifests/server. |
…unction, this would require a semver bump
|
Commit 4018348 should make this PR green, but it breaks the dns::member class. I'm not entirely sure what the dns::member class was used for. If someone wants to export the dns::member defined type, why not just do it in a profile? This might need to be broken into a separate PR and would require a full version bump. |
|
...and, for that matter, why create a defined type to export? Why not just export the record inside the member? Maybe I should just refactor it that way so it doesn't break this functionality... |
|
Hmm. I don't know.... Yea I would just junk that member stuff. I've pushed some cosmetic lint changes to master, feel free to merge or rebase. |
Reformatted dns::key and wrote tests for it
No description provided.