El compatible #41
El compatible #41
Conversation
- Split some parameters as named.conf could be in another place on some systems - include dns::server::params when needed (puppet lint says it's a bad idea to inherit it) - Align some symbols (=> or =) - Make some requirement more readable
- Use include of params instead inherit them - Remove useless requirements (parent dir)
|
I would love EL support as much as the next person, but please merge from master (fixes the 400) and re-pull with RHEL specific tests. |
Conflicts: manifests/server/options.pp
|
@sereinity @solarkennedy I am wondering, why the main /etc/named.conf file isn't managed by this module? |
|
Uh.. Hmmm... I don't know. PR? |
|
@solarkennedy Gladly, however I think you need to merge this PR so I can base mine on it. Or, I can merge this branch locally and create another PR (but then I will take @sereinity credit, which isn't good). Do you know a better way? |
|
Sorry for the delay. The aim of this PR is only to provide the support. I plane to add other settings in another PR, but first of all, this need to be merged. |
|
@sereinity You are right, I am actually using your branch instead of the master (with some modifications), so no doubt that I would like to see it merged too :) Maybe a good idea would be to use concat module to add the import to the main config file instead of managing the whole file ? |
|
@leonidlm The concat module couldn't append a fragment to a file not entirely managed by concat. But we can simply add an exec that concatenate the missing line if a grep fails. But from my point of view, it's only a workaround. |
|
@sereinity Ohh I see, so there is no other way. |
|
@sereinity can you rebase one more time please? |
|
Yes, I will do it Thursday. |
Conflicts: manifests/key.pp manifests/record.pp manifests/server/config.pp manifests/server/params.pp manifests/zone.pp spec/defines/dns__acl_spec.rb spec/defines/dns_zone_spec.rb
|
@leonidlm If you only need to include a single instead of managing the entire file, perhaps the file_line source in stdlib would do what you need. |
Make the module compatible with CentOs, RHEL, …