Added support for SRV DNS record types. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samcday This is still a desired feature, but it has been a long time. Can you pull from master to get up to date and be sure it works? I did say I would write tests, but I would encourage you to try first if you can. |
|
@solarkennedy honestly I haven't been doing much Puppet stuff in the last 6 months, so I'm pretty unfamiliar with what I even did here now ;) I won't really have the bandwidth or motivation to pursue this one any further. |
solarkennedy
added a commit
that referenced
this pull request
Apr 16, 2014
Added support for SRV DNS record types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Here's a quick patch to add a dns::record::srv definition.
Let me know if you have any queries!