Allow dynamic dns, fixes ajjahn/puppet-dns#54 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why travis is failing. In my environment it passed.
|
|
They are minor style issues. Don't worry about them for now unless you feel adventurous. |
| @@ -58,6 +58,10 @@ | |||
| # An array of IP addresses from which queries should be allowed | |||
| # Defaults to an empty array, which allows all ip to query the zone | |||
| # | |||
| # [*allow_update*] | |||
| # An array of IP addresses from which updates should be allowed | |||
| # Defaults to an empty array, which denies updates to the zone | |||
There was a problem hiding this comment.
This needs a warning, as it will probably surprise people that when they enable this, no other records for this zone will take effect.
sspreitzer
force-pushed
the
ticket/54-allow_dynamic_dns
branch
from
a0908f0
to
bca65da
Compare
|
Hi, the comment on the parameter was faulty. I changed it to reflect the situation better. |
sspreitzer
force-pushed
the
ticket/54-allow_dynamic_dns
branch
from
bca65da
to
d07c032
Compare
sspreitzer
force-pushed
the
ticket/54-allow_dynamic_dns
branch
from
d11bff1
to
795710d
Compare
|
Thanks! |
1 similar comment
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54