Comparison of: String >= Integer, is not possible #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis ran the tests ok. I'm not sure what that error might be. I you run the future parser in production with this module and want to ensure continued correctness, please feel free to make another PR enabling the future parser in the travis matrix to potentially catch other bugs. |
solarkennedy
added a commit
that referenced
this pull request
Feb 20, 2016
Comparison of: String >= Integer, is not possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version casues this error when using any of the wrapper classes for records:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Comparison of: String >= Integer, is not possible. Caused by 'A String is not comparable to a non String'. at /etc/puppetlabs/code/environments/production/modules/dns/manifests/record.pp:24:34 at /etc/puppetlabs/code/environments/production/modules/dns/manifests/record/cname.pp:19 on node
This error is caused by future parser not liking the comparison of integer and string, stole a really simple fix from: voxpupuli/puppet-nginx#684
Also of note I couldn't get the tests to run even on the master branch, gave me a "NameError: uninitialized constant Syck" error, if you know how to fix that I will run them. Tested with a clean gemset on Ruby 2.2.4.