Allow the dns::zone::slave_masters parameter to be an array #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note - i am working on adding spec tests to this; please hold :) |
|
This is good. While we have not been doing this regularly, can you add a docstring to Something like |
|
I'll add in documentation for all the parameters this evening. |
|
parameters documented |
|
Whoa! Awesome!! |
solarkennedy
added a commit
that referenced
this pull request
Jul 29, 2015
…sters Allow the dns::zone::slave_masters parameter to be an array
|
@jearls wins all the points. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just changes the
zone.erbtemplate to allow the@slave_mastersparameter to be an array, in which case it gets joined by";"semicolons; if it's not an array, it's interpolated directly, just like the previous behavior.