fix zone template's @allow_transfer check #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the zone template was including empty allow_transfer {} blocks because
a 0-length array was still being treated as "true". this PR changes
the check to verify that @allow_transfer is an array and has >0 size.
solarkennedy
added a commit
that referenced
this pull request
May 31, 2015
fix zone template's @allow_transfer check
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the zone template was including empty allow_transfer {} blocks because
a 0-length array was still being treated as "true". this PR changes
the check to verify that @allow_transfer is an array and has >0 size.