Make summary grid have multiple levels #893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made it so the output was sorted alphabetically. |
|
I'd prefer to split to subgroups only if there are more than 5 (or something) benchmarks. The number of benchmarks per class apparently varies between projects, and e.g. the scipy benchmark grid gets very long with this change. The CI test failures also appear real. |
pv
added
the
needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current summary grid can get pretty unwieldy when you have a lot of different benchmarks. This is a proposal for making it easier to read by nesting them in a tree-like fashion.
This assumes that you have a coherent hierarchy of benchmarks:
a.b.cwould be shadowed bya.b.