Bump react-with-styles-interface-css version #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-patch: fixes/refactors/etc
|
Changes Unknown when pulling 0a7db35 on maja-bump-react-with-styles-interface-css into ** on master**. |
ljharb
approved these changes
Oct 16, 2017
| { | ||
| "rules": { | ||
| "import/no-extraneous-dependencies": [2, { | ||
| "devDependencies": true |
There was a problem hiding this comment.
this can even be configured in the root .eslintrc, with glob-based configuration :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
react-with-styles-interface-cssincluded both the interface and the compiler. Because the compiler was doing some build step shenanigans to do compilation on the fly, it included a regular dependency onbabel-registerto do some babel compilation on the fly. This, of course, got passed down to consumers ofreact-dateswhich wasn't great.react-with-styles-interface-csssplit into ``react-with-styles-interface-cssandreact-with-styles-interface-css-compiler` in v3, and this PR addresses that change.to: @ljharb