Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DayPickerRangeController): del hovered-span modifier for new end date #523

Merged
merged 1 commit into from
May 26, 2017
Merged

fix(DayPickerRangeController): del hovered-span modifier for new end date #523

merged 1 commit into from
May 26, 2017

Conversation

tagoro9
Copy link
Contributor

@tagoro9 tagoro9 commented May 19, 2017

If not deleted, then when selecting a new range with an end date before the previous one, it will still keep the hovered-span modifier.

react_dates_bug

Steps to reproduce:

  • Select a range.
  • Select the same start date again.
  • Select an end date before the previous end date.
  • The end date keeps the CalendarDay--hovered-span when it shouldn't.

Fixes #520.

@tagoro9
fix(DayPickerRangeController): delete hovered-span modifier from new …
e0d65b8 
…enddate

* If not deleted, then when selecting a new range with an end date
before the previous one, it will still keep the hovered-span modifier.
@coveralls
Copy link

coveralls commented May 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.537% when pulling e0d65b8 on relayrides:end_date_hovered_span_class into 380e6f9 on airbnb:master.

majapw
majapw approved these changes May 26, 2017
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@majapw majapw merged commit 50a37a2 into react-dates:master May 26, 2017
@majapw majapw mentioned this pull request Jun 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tagoro9 @coveralls @majapw