Removes the short-lived tether dependency in react-dates #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Nov 4, 2016
| @@ -378,7 +424,11 @@ export default class DateRangePicker extends React.Component { | |||
| const onOutsideClick = !withFullScreenPortal ? this.onOutsideClick : undefined; | |||
|
|
|||
| return ( | |||
| <div className={this.getDayPickerContainerClasses()}> | |||
| <div | |||
| ref={ref => { this.dayPickerContainer = ref; }} | |||
There was a problem hiding this comment.
the linter should be requiring arg parens here
| @@ -224,7 +268,11 @@ export default class SingleDatePicker extends React.Component { | |||
| const onOutsideClick = !withFullScreenPortal ? this.onClearFocus : undefined; | |||
|
|
|||
| return ( | |||
| <div className={this.getDayPickerContainerClasses()}> | |||
| <div | |||
| ref={ref => { this.dayPickerContainer = ref; }} | |||
ljharb
added
the
semver-patch: fixes/refactors/etc
majapw
added
the
semver-major: breaking change
|
I think this is actually going to be a major bump because of the changes in DOM structure and classnames. |
mereskin-zz
reviewed
Nov 4, 2016
| const { dayPickerContainerStyles } = this.state; | ||
|
|
||
| const containerClientRect = this.dayPickerContainer.getBoundingClientRect(); | ||
| const documentBodyStyles = window.getComputedStyle(document.body); |
There was a problem hiding this comment.
This call is fairly expensive because it traverses the entire cascade and builds CSSDeclaration. Maybe we can call responsivizePickerPosition inside requestAnimationFrame, what do you think?
majapw
removed
the
semver-patch: fixes/refactors/etc
majapw
force-pushed
the
maja-kill-the-tether
branch
2 times, most recently
from
b5c472b
to
30cb93a
Compare
…just doing the thing internally
majapw
force-pushed
the
maja-kill-the-tether
branch
from
30cb93a
to
5799674
Compare
|
Most of these additions cannot really be well tested without DOM manipulation so I'm going to merge this in as is. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we're just going to do the thing internally.
Fix for #139 as well.
to: @moonboots @airbnb/webinfra
Ugh