Make hasClass work for mounted composite components
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assName, which allows ReactWrapper.hasClass to bypass the !isDOMComponent(inst) call
aweary
reviewed
Nov 12, 2016
| const wrapper = mount( | ||
| <div className="foo bar baz some-long-string FoOo" />, | ||
| ); | ||
| context('When using a DOM component', () => { |
There was a problem hiding this comment.
@ljharb are you OK with using context blocks here? I don't think we use them anywhere else, but it makes enough sense.
There was a problem hiding this comment.
context and describe are identical - either is fine, but i have a light preference for describe.
There was a problem hiding this comment.
Right, I know they're identical, it was just a question of preference.
aweary
approved these changes
Nov 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully?) address the long running issue #134, where
wrapper.hasClassalways returns false onmounted composite components. The reason for the failure is the following block inMountedTraversal.js#instHasClassName:Simply removing this block breaks many things, as the method is used internally in
MountedTraversal.js. My naive solution is to split the method in two, so we retain the exportedinstHasClassNamefunction for use byReactWrapper.hasClass, and extract a privatehasClassNamefunction for use internally inMountedTraversal.js.From here we can remove the
!isDOMComponentearly exit code frominstHasClassName, and instead add it tohasClassNameto maintain existing functionality.