Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Use sanitized URL as Location header in redirects #3614

Merged
merged 1 commit into from
Feb 17, 2019
Merged

[3.5] Use sanitized URL as Location header in redirects #3614

merged 1 commit into from
Feb 17, 2019

Conversation

m-burst
Copy link
Contributor

@m-burst m-burst commented Feb 17, 2019

Backport of #3613 for the 3.5 branch

@webknjaz webknjaz merged commit 74e3d74 into aio-libs:3.5 Feb 17, 2019
@m-burst m-burst deleted the fix-redirect-url-3.5 branch February 17, 2019 21:57
@m-burst
Copy link
Contributor Author

m-burst commented Feb 17, 2019

@webknjaz Looking at it again, I think this might be seen as breaking for some of the users who expect the location property on an HTTPFound object to be a string if they passed a string (and also I broke a test and made the mistake of not running them locally before opening the PR). Should I fix this in a follow-up PR?

@webknjaz
Copy link
Member

Odd... CI was green. I'm not sure what you mean but PR is welcome and we can go through a review process there :)

@m-burst
Copy link
Contributor Author

m-burst commented Feb 17, 2019

@webknjaz CI probably didn't fully run because the PR was merged very quickly.
Please see the fix in #3615.

@lock lock bot added the outdated label Feb 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants