Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async feature? #8

Open
aesteve opened this issue Jul 26, 2020 · 2 comments
Open

Async feature? #8

aesteve opened this issue Jul 26, 2020 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@aesteve
Copy link
Owner

aesteve commented Jul 26, 2020

Could investigate on a full async implementation, since people dealing with Vert.x will be used to such patterns already.

Maybe a different "feature" (like reqwest sync/async)?

@aesteve aesteve added the question Further information is requested label Jul 26, 2020
@aesteve aesteve self-assigned this Jul 26, 2020
@slinkydeveloper
Copy link

What about using refactoring to use tokio? You can make the whole library async and then people can use it in a "sync" way using blocking tokio executors. I can help if you want

@aesteve
Copy link
Owner Author

aesteve commented Jan 2, 2021

I experimented on a branch already.Tests are failing with 100% CPU use since I messed something up while reading the socket. I'll point you at it once I'm back home but implementing the protocol using tokio is way less easy than I thought it would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants