Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutor Types - Overlay and Notify Accessibility Concern #3501

Closed
tajuddinAherikar opened this issue Jan 17, 2024 · 2 comments
Closed

Tutor Types - Overlay and Notify Accessibility Concern #3501

tajuddinAherikar opened this issue Jan 17, 2024 · 2 comments

Comments

@tajuddinAherikar
Copy link

Description:

The current setup allows Tutor types - Overlay and Notify to be used without a title. This potential scenario raises concerns regarding accessibility, as popups lacking a title may lead to accessibility issues.

Your environment

  • version (AT 0.11.2/5.33.1)
  • Chrome v120.0.6099.217
  • Win 11

Steps to reproduce

  1. Navigate to [specific location or screen where Tutor types - Overlay and Notify are used].
  2. Trigger the Overlay and Notify functionalities without providing a title.

Expected behaviour

Default inclusion of a title for Tutor types - Overlay and Notify to ensure accessibility standards are met.

Actual behaviour

Tutor types - Overlay and Notify can be used without a title, potentially causing accessibility issues.

Screenshots

Notify
image

Overlay
image

@kirsty-hames
Copy link
Contributor

Hi @tajuddinAherikar, thanks for raising. I recently added an issue for this explaining the impacts on accessibility and the core functionality/plugins this relates too.

Your issue is specific to Tutor types which should be resolved by Core PR 484. The PR provides a default global title in the instance a _feedback.title isn't set.

Does this resolve your issue?

@tajuddinAherikar
Copy link
Author

Hi @kirsty-hames,

Thanks for your quick response. I've reviewed Core PR 484, and it seems to address the Tutor types issue by introducing a default global title when _feedback.title isn't set. This should resolve the problem. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants