Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib-assessment: assessment doesn't cope with _assessmentWeight not being set #1341

Closed
moloko opened this issue Nov 25, 2016 · 2 comments
Closed

contrib-assessment: assessment doesn't cope with _assessmentWeight not being set #1341

moloko opened this issue Nov 25, 2016 · 2 comments

Comments

@moloko
Copy link
Contributor

moloko commented Nov 25, 2016

If you don't have a valid _assessmentWeight property configured on your assessment article, the score sent to the LMS is NaN.

The code needs to handle this property being absent better - either by warning the user with a console.error or by defaulting the value to 1.
@chetan-hajare
Copy link

PR: adaptlearning/adapt-contrib-assessment#76

@moloko
Copy link
Contributor Author

moloko commented Nov 28, 2016

fixed by adaptlearning/adapt-contrib-assessment@e4c1c1b thanks @chetan-hajare

@moloko moloko closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @chetan-hajare