Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selector: [phones] Assessment MLP/PLP #1286

Closed
kineotesting opened this issue Oct 11, 2016 · 9 comments
Closed

Language selector: [phones] Assessment MLP/PLP #1286

kineotesting opened this issue Oct 11, 2016 · 9 comments
Assignees
Labels

Comments

@kineotesting
Copy link

kineotesting commented Oct 11, 2016

I can't seem to get the Assessment MLP or PLP to complete properly on 100% score in any language.The MLP always seems show as partially complete, and the PLP will only sometimes show complete. Also, on the iPhone 6 iOS 10, if I pass the Assessment with 100% score, exit the topic (not the course) and reenter, the nav bar loses functionality--selecting a nav button with cause the transparent white overlay to appear but not the relevant drawer.

Update: I'm only seeing this on uploads that have spoor enabled.

@kineotesting kineotesting changed the title Language selector: [iPhone iOS 9] Assessment MLP/PLP Language selector: [iPhone iOS 10] Assessment MLP/PLP Oct 11, 2016
@kineotesting kineotesting changed the title Language selector: [iPhone iOS 10] Assessment MLP/PLP Language selector: [phones] Assessment MLP/PLP Oct 11, 2016
@lc-thomasberger lc-thomasberger self-assigned this Oct 11, 2016
@lc-thomasberger lc-thomasberger added this to the multilang support milestone Oct 11, 2016
@lc-thomasberger
Copy link
Member

issue with the nav bar is probably the same as described in this issue: #1277

So when you switch from rtl to ltr

@lc-thomasberger
Copy link
Member

That's how I can replicate ths bug also on Desktop:
When the first attempt is 100%, PLP and MLP show a 100% score.
When first attempt fail and next attempt is 100%, MLP and PLP do not show a full 100%

@lc-thomasberger
Copy link
Member

On every language change, Adapt.assessment.register() is called.
For progress calculation, total uses every Assessment and not just the ines for each language.

@oliverfoster
Copy link
Member

try on line https://github.com/adaptlearning/adapt-contrib-assessment/blob/master/js/assessment.js#L211

if (this._assessments._byAssessmentId.hasOwnProperty(assessmentId)) return;

@oliverfoster
Copy link
Member

issue nullified by assessments reset on language change PR > adaptlearning/adapt-contrib-assessment#75

@kineotesting
Copy link
Author

kineotesting commented Oct 17, 2016

Fixed, but now, if I fail the assessment, the PLP and MLP show as complete too (previously if you'd failed, they'd show partially completed as is standard I think).

@moloko
Copy link
Contributor

moloko commented Oct 17, 2016

I just tried failing the assessment on an older version of Adapt I had from back in August (framework v 2.0.11, assessment 2.0.6, PLP 2.0.6) and initially both the page-PLP and menu-PLP showed completed progress. It was only when I then went back into the assessment that they both updated. So maybe this has been an issue for a while?

@moloko
Copy link
Contributor

moloko commented Oct 17, 2016

same results on a copy of adapt I have from back in Sept (framework 2.0.12, assessment 2.0.6, PLP 2.0.7)

But I do get what Jen (@kineotesting) is saying though, I thought it showed as partially completed if you failed. Odd.

@lc-thomasberger
Copy link
Member

Tested with Version 2.0.12 of the Framework and Version 2.0.6 of Assessment. So the Versions before the ML-feature work.

When you fail the assessment, PLP on the page with Assessment is full. When you go back to the Menu, MLP is also full. Matches the PLP, which is exactly what I would expect.

When I revisit the page with the Assessment, the PLP changes into "partial", when I go back to the Menu, MLP matches again the PLP value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants