-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language selector: [phones] Assessment MLP/PLP #1286
Comments
issue with the nav bar is probably the same as described in this issue: #1277 So when you switch from rtl to ltr |
That's how I can replicate ths bug also on Desktop: |
On every language change, Adapt.assessment.register() is called. |
try on line https://github.com/adaptlearning/adapt-contrib-assessment/blob/master/js/assessment.js#L211
|
issue nullified by assessments reset on language change PR > adaptlearning/adapt-contrib-assessment#75 |
Fixed, but now, if I fail the assessment, the PLP and MLP show as complete too (previously if you'd failed, they'd show partially completed as is standard I think). |
I just tried failing the assessment on an older version of Adapt I had from back in August (framework v 2.0.11, assessment 2.0.6, PLP 2.0.6) and initially both the page-PLP and menu-PLP showed completed progress. It was only when I then went back into the assessment that they both updated. So maybe this has been an issue for a while? |
same results on a copy of adapt I have from back in Sept (framework 2.0.12, assessment 2.0.6, PLP 2.0.7) But I do get what Jen (@kineotesting) is saying though, I thought it showed as partially completed if you failed. Odd. |
Tested with Version 2.0.12 of the Framework and Version 2.0.6 of Assessment. So the Versions before the ML-feature work. When you fail the assessment, PLP on the page with Assessment is full. When you go back to the Menu, MLP is also full. Matches the PLP, which is exactly what I would expect. When I revisit the page with the Assessment, the PLP changes into "partial", when I go back to the Menu, MLP matches again the PLP value. |
I can't seem to get the Assessment MLP or PLP to complete properly on 100% score in any language.The MLP always seems show as partially complete, and the PLP will only sometimes show complete. Also, on the iPhone 6 iOS 10, if I pass the Assessment with 100% score, exit the topic (not the course) and reenter, the nav bar loses functionality--selecting a nav button with cause the transparent white overlay to appear but not the relevant drawer.
Update: I'm only seeing this on uploads that have spoor enabled.
The text was updated successfully, but these errors were encountered: