Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question component notify popup #100

Closed
fosterc1 opened this issue May 17, 2023 · 6 comments · Fixed by #101
Closed

Question component notify popup #100

fosterc1 opened this issue May 17, 2023 · 6 comments · Fixed by #101
Assignees

Comments

@fosterc1
Copy link

Subject of the issue/enhancement/features

Since the latest FW version when the feedback for any question component is viewed, then another page visited and the page with the original question revisited the notify/feedback is automatically displayed.

Your environment

  • version (AT v0.11.1/Framework v5.31.4)
  • which browser and its version - all browsers
  • device(s) + operating system(s) - MacOS

Steps to reproduce

Submitted an answer to any question component, viewed feedback. Closed the feedback and the progressed to next page. Revisited previous page with answered question.

Expected behaviour

After revisiting the page the notify/feedback popup should not be automatically displayed

Actual behaviour

Feedback/notify is automatically displayed

Screenshots (if you can)

2023-05-17_14-50-38
2023-05-17_14-51-04

@oliverfoster
Copy link
Member

Can you check that tutor is up to date? Duplicate of #91

@swashbuck
Copy link

@oliverfoster I am able to reproduce this when course.json contains Tutor settings:

  "_tutor": {
    "_type": "notify",
    "_classes": "",
    "_hasNotifyBottomButton": false,
    "_button": {
      "text": "{{_globals._extensions._tutor.hideFeedback}}",
      "ariaLabel": "{{_globals._extensions._tutor.hideFeedback}}"
    }
  },

I noticed this today in the authoring tool where, presumably, Tutor settings are always added.

@fosterc1
Copy link
Author

Hello @oliverfoster

Tutor is upto date v4.5.7

Thanks

@swashbuck
Copy link

I think this is the same issue as #94

@oliverfoster oliverfoster transferred this issue from adaptlearning/adapt_framework Jun 1, 2023
@oliverfoster oliverfoster self-assigned this Jun 1, 2023
@oliverfoster
Copy link
Member

Should be fixed with pr #101

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🎉 This issue has been resolved in version 4.5.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants